Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix warning on VS2017 [19882] #176

Merged
merged 3 commits into from
Nov 13, 2023
Merged

Fix warning on VS2017 [19882] #176

merged 3 commits into from
Nov 13, 2023

Conversation

richiware
Copy link
Member

No description provided.

Signed-off-by: Ricardo González <correoricky@gmail.com>
@richiware richiware changed the title Fix warning on VS2017 Fix warning on VS2017 [19882] Nov 10, 2023
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM though there is one file whose changes need to be reverted. Let us wait for the CI results and as the changes does not affect the CI, we can proceed and merge.

fastcdr.repos Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, revert changes in this file.

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware merged commit cc994b0 into master Nov 13, 2023
9 of 10 checks passed
@richiware richiware deleted the bugfix/warning-vs2017 branch November 13, 2023 13:27
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants