Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support serializing a std::vector as an array. #192

Merged
merged 5 commits into from
Feb 14, 2024

Conversation

richiware
Copy link
Member

This PR adds API for encoding/decoding a std::vector as an array. This API is needed for Fast DDS 3.0 Dynamic Types.

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@JLBuenoLopez
Copy link
Contributor

@richiprosima please test Windows

Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but, do we need to extend the test suite to include test cases that check this new feature?

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
fastcdr.repos Outdated Show resolved Hide resolved
test/cdr/array_as_std_vector.cpp Outdated Show resolved Hide resolved
test/cdr/array_as_std_vector.cpp Outdated Show resolved Hide resolved
test/cdr/array_as_std_vector.cpp Outdated Show resolved Hide resolved
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@JLBuenoLopez JLBuenoLopez merged commit 7417ff1 into master Feb 14, 2024
14 checks passed
@JLBuenoLopez JLBuenoLopez deleted the feature/vector-as-array branch February 14, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants