Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20091] Add macOS to gihub actions testing #197

Merged
merged 6 commits into from
Feb 20, 2024
Merged

[20091] Add macOS to gihub actions testing #197

merged 6 commits into from
Feb 20, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Feb 18, 2024

This PR adds macOS 13 to the list of platforms tested in Github CI. Depends on:

@Mergifyio backport 1.1.x 1.0.x

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz marked this pull request as ready for review February 18, 2024 08:56
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added the needs-review Mark this PR as ready to be reviewed label Feb 18, 2024
@EduPonz EduPonz added this to the v2.2.0 milestone Feb 18, 2024
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though I will approve after the tags have been updated with the proper eProsima CI release.

.github/workflows/fastcdr-test.yml Outdated Show resolved Hide resolved
.github/workflows/fastcdr-test.yml Show resolved Hide resolved
@EduPonz EduPonz removed the needs-review Mark this PR as ready to be reviewed label Feb 19, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 835500b into master Feb 20, 2024
15 of 16 checks passed
@EduPonz EduPonz deleted the ci/mac branch February 20, 2024 07:23
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

EduPonz added a commit that referenced this pull request Feb 22, 2024
* Refs #20091: Add macOS to gihub actions testing

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20091: Fix python version

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20091: Build Gtest in macos

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20091: Cleanup workflow

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20091: Add colcon.meta for googletest

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20091: Set eProsima-CI actions to v0

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants