[20327] Do not build test if CMake < 3.22 #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
|
Github CI running here |
MiguelCompany
approved these changes
Mar 25, 2024
|
Here's a CI run on RHEL on ROS 2 infrastructure with this in place:
|
That looks good to me; the one flaky test there is unrelated with this PR. |
|
With the Github CI, I don't think we need to wait for the Jenkins queue for Mac. Going in. |
|
Build status:
|
JesusPoderoso
pushed a commit
that referenced
this pull request
Jul 1, 2024
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR avoids building the tests if CMake < 3.22 even when specified via CMake option.