Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20733] Document how to annotate members as key in XML types #746

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Apr 17, 2024

Description

This PR documents how to annotate members as key in XML types (@key equivalent)

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Related implementation PR:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

Signed-off-by: eduponz <eduardoponz@eprosima.com>
@EduPonz EduPonz force-pushed the hotfix/key_annotation_xml_types branch from 7b33a8d to b78c9c7 Compare April 25, 2024 09:01
@EduPonz
Copy link
Author

EduPonz commented Apr 25, 2024

@richiprosima please test this

@MiguelCompany MiguelCompany added the implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS label Apr 29, 2024
@MiguelCompany MiguelCompany merged commit f95e5c9 into master Apr 30, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/key_annotation_xml_types branch April 30, 2024 05:53
@MiguelCompany
Copy link
Member

@Mergifyio backport 2.13.x 2.10.x 2.6.x

Copy link

mergify bot commented Apr 30, 2024

backport 2.13.x 2.10.x 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Apr 30, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit f95e5c9)
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit f95e5c9)
mergify bot pushed a commit that referenced this pull request Apr 30, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit f95e5c9)

# Conflicts:
#	code/XMLTester.xml
JesusPoderoso pushed a commit that referenced this pull request May 10, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit f95e5c9)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
MiguelCompany pushed a commit that referenced this pull request May 17, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit f95e5c9)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Mario-DL added a commit that referenced this pull request Jun 27, 2024
* Document how to annotate member as key in XMl types (#746)

Signed-off-by: eduponz <eduardoponz@eprosima.com>
(cherry picked from commit f95e5c9)

# Conflicts:
#	code/XMLTester.xml

* Refs #21244: Solve conflicts

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>

---------

Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com>
Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Co-authored-by: Mario Dominguez <mariodominguez@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
implementation-pending Marks doc PRs which corresponding implementation is not yet available on Fast DDS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants