Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding default ctor to interprocess_semaphore <1.10.x> [8229] #1169

Merged
merged 4 commits into from
Apr 22, 2020
Merged

Adding default ctor to interprocess_semaphore <1.10.x> [8229] #1169

merged 4 commits into from
Apr 22, 2020

Conversation

adolfomarver
Copy link
Contributor

@adolfomarver adolfomarver commented Apr 22, 2020 •
edited by MiguelCompany
Loading

This should fix #1168
Signed-off-by: AdolfoMartinez adolfomartinez@eprosima.com

@adolfomarver
Fix build fail in ROS-CI.
c2fc535 
Signed-off-by: AdolfoMartinez <adolfomartinez@eprosima.com>
@adolfomarver adolfomarver changed the title Fix build fail in ROS-CI. PR1147 build fail on ROS-CI / MAC <1.10.x> [8229] Apr 22, 2020
@adolfomarver adolfomarver changed the title PR1147 build fail on ROS-CI / MAC <1.10.x> [8229] #1147 build fail on ROS-CI / MAC <1.10.x> [8229] Apr 22, 2020
@MiguelCompany
Apply suggestions from code review
8297085 
Signed-off-by: Miguel Company <MiguelCompany@eprosima.com>
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

MiguelCompany
MiguelCompany previously approved these changes Apr 22, 2020
View reviewed changes
@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany changed the title #1147 build fail on ROS-CI / MAC <1.10.x> [8229] Adding default constructor to interprocess_semaphore <1.10.x> [8229] Apr 22, 2020
@MiguelCompany MiguelCompany changed the title Adding default constructor to interprocess_semaphore <1.10.x> [8229] Adding default ctor to interprocess_semaphore <1.10.x> [8229] Apr 22, 2020
@MiguelCompany MiguelCompany linked an issue Apr 22, 2020 that may be closed by this pull request
osX build broken in 1.10.x branch #1168
Closed
@MiguelCompany MiguelCompany mentioned this pull request Apr 22, 2020
Closed
@adolfomarver
Fix boost::interprocess::semaphore initialization.
824e861 
Signed-off-by: AdolfoMartinez <adolfomartinez@eprosima.com>
MiguelCompany
MiguelCompany previously approved these changes Apr 22, 2020
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware
Copy link
Member

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@MiguelCompany MiguelCompany merged commit be1afe5 into 1.10.x Apr 22, 2020
@MiguelCompany MiguelCompany deleted the bug/pr1147_build_fail branch April 22, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

osX build broken in 1.10.x branch
3 participants
@adolfomarver @richiware @MiguelCompany