Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix <2.0.x> build and bump Fast CDR to <1.0.20> [10710] #1793

Merged
merged 2 commits into from
Mar 2, 2021

Conversation

JLBuenoLopez
Copy link
Contributor

Building <2.0.x> with the tests enabled failed due to source files being missed. This PR removes these files from the CMakeLists.txt.

Also, it bumps the Fast CDR version to <1.0.20> because BuiltinDataSerializationTests only pass with at least this release.

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JLBuenoLopez JLBuenoLopez changed the title Fix <2.0.x> build and bump Fast CDR to <1.0.20> Fix <2.0.x> build and bump Fast CDR to <1.0.20> [10710 Mar 1, 2021
@JLBuenoLopez JLBuenoLopez changed the title Fix <2.0.x> build and bump Fast CDR to <1.0.20> [10710 Fix <2.0.x> build and bump Fast CDR to <1.0.20> [10710] Mar 1, 2021
@JLBuenoLopez
Copy link
Contributor Author

CI failures seem unrelated

@MiguelCompany MiguelCompany merged commit 53a3455 into 2.0.x Mar 2, 2021
@MiguelCompany MiguelCompany deleted the bugfix/fix_build branch March 2, 2021 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants