Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dns filter in CMakeLists file #4137

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix dns filter in CMakeLists file #4137

merged 1 commit into from
Dec 15, 2023

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Dec 14, 2023 •
edited by EduPonz
Loading

Description

Fix dns filter of tests in CMakeLists file

Contributor Checklist

  • N/A Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

@Mergifyio backport 2.12.x 2.11.x 2.10.x

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf
Fix dns filter in CMakeLists file
d352301 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf added this to the v2.13.0 milestone Dec 14, 2023
@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Dec 14, 2023
@elianalf
Copy link
Contributor Author

@Mergifyio backport 2.12.x 2.11.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 14, 2023 •
edited
Loading

backport 2.12.x 2.11.x 2.10.x

🟠 Pending

JesusPoderoso
JesusPoderoso approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac

1 similar comment
@EduPonz
Copy link

EduPonz commented Dec 14, 2023

@richiprosima please test mac

@EduPonz EduPonz merged commit 7c75b6d into master Dec 15, 2023
11 of 14 checks passed
@EduPonz EduPonz deleted the fix/dns_filter branch December 15, 2023 06:25
mergify bot pushed a commit that referenced this pull request Dec 15, 2023
@elianalf @mergify
Fix dns filter in CMakeLists file (#4137)
cf86dae 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 7c75b6d)
@mergify mergify bot mentioned this pull request Dec 15, 2023
Merged
@EduPonz
Copy link

EduPonz commented Dec 15, 2023

@Mergifyio backport 2.12.x 2.11.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 15, 2023 •
edited
Loading

backport 2.12.x 2.11.x 2.10.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 15, 2023
@elianalf @mergify
Fix dns filter in CMakeLists file (#4137)
d5f8d13 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 7c75b6d)
@mergify mergify bot mentioned this pull request Dec 15, 2023
Merged
mergify bot pushed a commit that referenced this pull request Dec 15, 2023
@elianalf @mergify
Fix dns filter in CMakeLists file (#4137)
cbcdc3c 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 7c75b6d)
@mergify mergify bot mentioned this pull request Dec 15, 2023
Merged
@EduPonz EduPonz mentioned this pull request Dec 15, 2023
Merged
18 tasks
EduPonz pushed a commit that referenced this pull request Dec 18, 2023
@mergify @elianalf
Fix dns filter in CMakeLists file (#4137) (#4144)
8f48bbc 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 7c75b6d)

Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request Dec 18, 2023
@mergify @elianalf
Fix dns filter in CMakeLists file (#4137) (#4142)
6491303 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 7c75b6d)

Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request Dec 18, 2023
@mergify @elianalf
Fix dns filter in CMakeLists file (#4137) (#4143)
8864728 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
(cherry picked from commit 7c75b6d)

Co-authored-by: elianalf <62831776+elianalf@users.noreply.github.com>
EduPonz pushed a commit that referenced this pull request Dec 20, 2023
@elianalf @EduPonz
Fix dns filter in CMakeLists file (#4137)
40e11be 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @JesusPoderoso @EduPonz