[20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows #4558

EduPonz · 2024-03-15T06:12:23Z

Description

Since the roll out of Github Ubuntu 22.04 (20240310) Image, ASan and TSan jobs have been failing. The issue was reported in actions/runner-images#9491 and fixed in actions/runner-images#9513. Until that fix is deployed, this PR:

Sets kernel param vm.mmap_rnd_bits to 28 as a workaround
Pins the CMake version used in all 3 sanitizer jobs.

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

Contributor Checklist

Commit messages follow the project guidelines.
N/A: The code follows the style guidelines of this project.
N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
N/A: Changes are ABI compatible.
N/A: Changes are API compatible.
N/A: New feature has been added to the versions.md file (if applicable).
N/A: New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.

Reviewer Checklist

The PR has a milestone assigned.
The title and description correctly express the PR's purpose.
Check contributor checklist is correct.
Check CI results: changes do not issue any warning.
Check CI results: failing tests are unrelated with the changes.

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz · 2024-03-15T17:03:15Z

@Mergifyio backport 2.13.x 2.12.x 2.10.x 2.6.x

mergify · 2024-03-15T17:03:40Z

backport 2.13.x 2.12.x 2.10.x 2.6.x

✅ Backports have been created

#4566 [20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows (backport #4558) has been created for branch 2.13.x but encountered conflicts
#4567 [20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows (backport #4558) has been created for branch 2.12.x but encountered conflicts
#4568 [20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows (backport #4558) has been created for branch 2.10.x but encountered conflicts
#4569 [20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows (backport #4558) has been created for branch 2.6.x but encountered conflicts

…#4558) * Refs #20542: Fix CMake version in sanitizer workflows Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Install correct version of Gtest Signed-off-by: EduPonz <eduardoponz@eprosima.com> * fixup! Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Set number of random bits for mmap to 28 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Fix asan_colcon.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Use CCache also for ASan DS Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 0c439a0) # Conflicts: # .github/workflows/address-sanitizers.yaml # .github/workflows/config/asan_colcon.meta # .github/workflows/thread-sanitizer.yaml

…#4558) * Refs #20542: Fix CMake version in sanitizer workflows Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Install correct version of Gtest Signed-off-by: EduPonz <eduardoponz@eprosima.com> * fixup! Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Set number of random bits for mmap to 28 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Fix asan_colcon.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Use CCache also for ASan DS Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 0c439a0) Signed-off-by: EduPonz <eduardoponz@eprosima.com>

…#4558) * Refs #20542: Fix CMake version in sanitizer workflows Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Install correct version of Gtest Signed-off-by: EduPonz <eduardoponz@eprosima.com> * fixup! Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Set number of random bits for mmap to 28 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Fix asan_colcon.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Use CCache also for ASan DS Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 0c439a0)

…#4558) * Refs #20542: Fix CMake version in sanitizer workflows Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Install correct version of Gtest Signed-off-by: EduPonz <eduardoponz@eprosima.com> * fixup! Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Set number of random bits for mmap to 28 Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Fix asan_colcon.meta Signed-off-by: EduPonz <eduardoponz@eprosima.com> * Refs #20542: Use CCache also for ASan DS Signed-off-by: EduPonz <eduardoponz@eprosima.com> --------- Signed-off-by: EduPonz <eduardoponz@eprosima.com> (cherry picked from commit 0c439a0) Signed-off-by: EduPonz <eduardoponz@eprosima.com>

…#4566) * Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Install correct version of Gtest * fixup! Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Set number of random bits for mmap to 28 * Refs #20542: Fix asan_colcon.meta * Refs #20542: Use CCache also for ASan DS --------- (cherry picked from commit 0c439a0) Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>

…#4567) * Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Install correct version of Gtest * fixup! Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Set number of random bits for mmap to 28 * Refs #20542: Fix asan_colcon.meta * Refs #20542: Use CCache also for ASan DS --------- (cherry picked from commit 0c439a0) Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>

…#4568) * Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Install correct version of Gtest * fixup! Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Set number of random bits for mmap to 28 * Refs #20542: Fix asan_colcon.meta * Refs #20542: Use CCache also for ASan DS --------- (cherry picked from commit 0c439a0) Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>

…#4569) * Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Install correct version of Gtest * fixup! Refs #20542: Fix CMake version in sanitizer workflows * Refs #20542: Set number of random bits for mmap to 28 * Refs #20542: Fix asan_colcon.meta * Refs #20542: Use CCache also for ASan DS --------- (cherry picked from commit 0c439a0) Signed-off-by: EduPonz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>

Refs #20542: Fix CMake version in sanitizer workflows

0fe1e70

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz added this to the v2.14.0 - Frozen milestone Mar 15, 2024

Refs #20542: Install correct version of Gtest

79cab5b

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz force-pushed the ci/fix_cmake_sanitizer_workflows branch 3 times, most recently from 3c8b473 to 32e6306 Compare March 15, 2024 09:41

EduPonz added 2 commits March 15, 2024 11:25

fixup! Refs #20542: Fix CMake version in sanitizer workflows

b3bccef

Refs #20542: Set number of random bits for mmap to 28

4f9af87

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz force-pushed the ci/fix_cmake_sanitizer_workflows branch from 32e6306 to 4f9af87 Compare March 15, 2024 10:28

EduPonz changed the title ~~[20542] Pin CMake version in sanitizer workflows~~ [20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows Mar 15, 2024

Mario-DL previously approved these changes Mar 15, 2024

View reviewed changes

MiguelCompany previously approved these changes Mar 15, 2024

View reviewed changes

Refs #20542: Fix asan_colcon.meta

54a5df1

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

EduPonz dismissed stale reviews from MiguelCompany and Mario-DL via 54a5df1 March 15, 2024 11:34

Refs #20542: Use CCache also for ASan DS

5e7d00b

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

MiguelCompany approved these changes Mar 15, 2024

View reviewed changes

EduPonz merged commit 0c439a0 into master Mar 15, 2024
6 of 10 checks passed

EduPonz deleted the ci/fix_cmake_sanitizer_workflows branch March 15, 2024 17:03

mergify bot mentioned this pull request Mar 15, 2024

[20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows (backport #4558) #4569

Merged

7 tasks

EduPonz mentioned this pull request Mar 16, 2024

[20630] Use correct version of GTest on DS ASan tests #4571

Merged

7 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows #4558

[20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows #4558

EduPonz commented Mar 15, 2024 •

edited by MiguelCompany

Loading

EduPonz commented Mar 15, 2024

mergify bot commented Mar 15, 2024 •

edited

Loading

[20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows #4558

[20542] Pin CMake version and vm.mmap_rnd_bits in sanitizer workflows #4558

Conversation

EduPonz commented Mar 15, 2024 • edited by MiguelCompany Loading

Description

Contributor Checklist

Reviewer Checklist

EduPonz commented Mar 15, 2024

mergify bot commented Mar 15, 2024 • edited Loading

✅ Backports have been created

EduPonz commented Mar 15, 2024 •

edited by MiguelCompany

Loading

mergify bot commented Mar 15, 2024 •

edited

Loading