[18002] Internal refactor on port handling (backport #3440) #4698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
* Refs #18002. Avoid mutation of multicast ports. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18002. Move security initalization up. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18002. Prepare for refactor of locators setup. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18002. Refactor metatraffic related code. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18002. Refactor initial peers related code. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18002. Refactor user traffic related code. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18002. Refactor output traffic related code. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18002. Safe metatraffic unicast port on a new attribute. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18002. User unicast port calculated on participant instead of NetworkFactory. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Refs #18002. Update metatraffic_unicast_port_ inside applyLocatorAdaptRule. Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> * Apply suggestion Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #18002. Always create unicast receiver resources first. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #18002. Improve warning message. Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #18002. Refactor createReceiverResources Signed-off-by: Miguel Company <miguelcompany@eprosima.com> * Refs #18002. Improve SHM.SamePortUnicastMulticast blackbox test Signed-off-by: Miguel Company <miguelcompany@eprosima.com> --------- Signed-off-by: Miguel Company <MiguelCompany@eprosima.com> Signed-off-by: Miguel Company <miguelcompany@eprosima.com> (cherry picked from commit ea5af48) # Conflicts: # src/cpp/rtps/network/NetworkFactory.h # src/cpp/rtps/participant/RTPSParticipantImpl.cpp
|
Cherry-pick of ea5af48 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
9 tasks
Signed-off-by: Miguel Company <miguelcompany@eprosima.com>
MiguelCompany
force-pushed
the
mergify/bp/2.10.x/pr-3440
branch
from
047ac5a
to
e1410b1
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
|
@richiprosima Please test this |
|
@richiprosima please test mac |
|
@richiprosima Please test mac |
3 similar comments
|
@richiprosima Please test mac |
|
@richiprosima Please test mac |
|
@richiprosima Please test mac |
MiguelCompany
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the constructor of RTPSParticipantImpl, and changes the calculation of the ports used when set to 0 on the input locators.
@Mergifyio backport 2.13.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
N/A: Any new/modified methods have been properly documented using Doxygen.
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #3440 done by [Mergify](https://mergify.com).