Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting sleep timer causes the current track to pause #20

Closed
sreknob opened this issue Jun 6, 2017 · 3 comments
Closed

Setting sleep timer causes the current track to pause #20

sreknob opened this issue Jun 6, 2017 · 3 comments
Labels

Comments

@sreknob
Copy link

sreknob commented Jun 6, 2017

I've been trying to figure this out for a while and just realized that it's homebridge-zp causing the problem when I tailed the log. With music playing when I select a sleep timer the track pauses and needs to be restarted. Log looks like this:
[ZP] Office Sonos: current track changed from Yellow Submarine to The Curse Of Comfort
[ZP] Office Sonos: power (play/pause) changed from true to undefined
[ZP] Office Sonos: set power (play/pause) from undefined to false
[ZP] Office Sonos: current track changed from The Curse Of Comfort to undefined
[ZP] Office Sonos: power (play/pause) changed from undefined to false
[ZP] Office Sonos: current track changed from undefined to The Curse Of Comfort
This happens every time I select a sleep timer duration or change the duration.
Thanks for looking into this!

@ebaauw
Copy link
Owner

ebaauw commented Jun 6, 2017

Thanks for noticing this! I found the same behaviour recently, but hadn't linked it to homebridge-zp. I did change the logic regarding power (play/pause), see #12 (comment), maybe introducing this behaviour. I'll definitely have a look.

ebaauw added a commit that referenced this issue Jun 6, 2017
Setting sleep timer causes an AVTransport event with TransportState nor
CurrentTrackMetaData, so we should initialise on and track to current
settings.
@ebaauw
Copy link
Owner

ebaauw commented Jun 6, 2017

Yup, this is a bug introduced in v0.2.1. Solved in v0.2.3, which I just published.

@ebaauw ebaauw added the bug label Jun 6, 2017
@sreknob
Copy link
Author

sreknob commented Jun 6, 2017

Amazing, many thanks!
Just updated and issue resolved.
Don't tell Sonos support (whom I've been bugging for a month) that this was the issue. LOL

@sreknob sreknob closed this as completed Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants