WIP: Bind validation #3102
Closed
WIP: Bind validation #3102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively validates DB inserts/updates of JSONs at Ebean level.
Use case/Problem 1:
inserts for JSON columns, that have a length specified may work on one database (where "clob" is used for json) and fail on an other where a size limited type (e.g. varchar(1000)) is used.
Problem 2:
Some databases will silently truncate strings (or also other data types) See "TestMetaAnnotations"
This change will allow ebean to validate the string lengths of JSONs
Will provide more infos.