Fix continue-on-error behavior in GitHub Actions #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the `matrix.continue-on-error` setting is only ever defined for
nightly Rust build jobs, all other jobs will trigger a CI error if they
fail:
```
Error: Process completed with exit code 101.
Error: .github/workflows/rust.yml (Line: 31, Col: 26): Unexpected value ''
Error: The step failed and an error occurred when attempting to determine whether to continue on error.
Error: The template is not valid. .github/workflows/rust.yml (Line: 31, Col: 26): Unexpected value ''
```
The output above indicates that `matrix.continue-on-error` defaults to
an empty string if it's not explicitly defined for the current job in
the matrix. The `continue-on-error: ${{ matrix.continue-on-error }}`
evaluation then fails due to expecting a `bool` value.
I've tried specifying a default value of `continue-on-error: [false]` in
the matrix, but attempting to override this default setting using
`include` just creates more build jobs with `continue-on-error: true`
instead of overriding the setting for the existing ones, which isn't
what we want.
The solution I found was to append `|| false` to the end, which coerces
the type to `false` if the setting is undefined for the current job.
This suppresses the error message and produces the original expected
behavior.
ebkalderon
force-pushed
the
fix-continue-on-error-github-actions
branch
from
accd724
to
8f0e510
Compare
|
Seems there are some spurious errors occurring lately in the As far as I can tell from the logs, this seems like a platform and toolchain-specific IO issue. I think we should temporarily disable this job for the time being. At least |
ebkalderon
force-pushed
the
fix-continue-on-error-github-actions
branch
3 times, most recently
from
38ececf
to
2d874ef
Compare
There seem to be some spurious I/O errors on macOS beta toolchain builds
lately which are causing error messages similar to the one below to
display during test runs:
```
Error: thread 'service::tests::initializes_only_once' panicked at 'called `Result::unwrap()` on an `Err` value: Os { code: 22, kind: InvalidInput, message: "Invalid argument" }', src/service.rs:196:66
```
Likewise, 1.52.1 stable appears to be affected as well.
It seems that switching to `#[tokio::test(flavor = "current_thread")]`
everywhere resolves these issues, so perhaps there is a regression in
`tokio` somewhere on macOS? At least this unblocks CI.
ebkalderon
force-pushed
the
fix-continue-on-error-github-actions
branch
from
2d874ef
to
851ffc2
Compare
|
Nope, it seems that Rust 1.52.1 stable on macOS is affected by this issue as well, so these don't appear to be transient errors. I've found that switching all the test cases over to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
matrix.continue-on-errortoboolin therust.ymlworkflow. Should fix the erroneous behavior seen in Support null and negative integer request IDs #285 during the macOS builds. See the first commit message for details.#[tokio::test(flavor = "current_thread")]to fix failing macOS test jobs in CI.