switching from log facade to tracing #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me, as an initial effort! It would be great if we could leverage the futures instrumentation facilities of Would you mind fixing the conflicts in the |
|
Yes. I will fix it. |
|
@ebkalderon done 😄 |
ebkalderon
approved these changes
Apr 25, 2022
There was a problem hiding this comment.
Looks great! Thanks for getting this PR working. ❤️
One final request: it seems that #312 has introduced merge conflicts in the Cargo.toml and CHANGELOG.md again. Would you perhaps mind rebasing your branch one last time? Apologies, and thanks again for your contribution.
|
done. @ebkalderon |
|
Thanks for the PR and for your patience getting this merged! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #283