Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate support for lsp-types 0.94.0 #375

Merged
merged 6 commits into from
Feb 28, 2023
Merged

Conversation

ebkalderon
Copy link
Owner

Added

  • Add support for client-to-server textDocument/prepareTypeHierarchy, typeHierarchy/supertypes, and typeHierarchy/subtypes requests.
  • Add support for client-to-server textDocument/inlineValue request.
  • Add support for client-to-server textDocument/inlayHint and inlayHint/resolve requests.
  • Add support for client-to-server workspaceSymbol/resolve request.
  • Add support for server-to-client window/showDocument request (from 3.16.0, but was missed).
  • Add support for server-to-client workspace/inlineValue/refresh request.
  • Add support for server-to-client workspace/inlayHint/refresh request.

Changed

  • Reorder and group LanguageServer trait methods to better match LSP 3.17.0 spec document.
  • Reorder and group Client methods to better match LSP 3.17.0 spec document.

Fixed

  • Improve LanguageServer and Client method documentation.

This pull request integrates support for most major 3.17.0 features introduced in lsp-types 0.94.0. After this pull request is merged, we should be able to push out a new release of tower-lsp.

It does not add support for window/workDoneProgress/cancel (#176) nor textDocument/diagnostic or workspace/diagnostic (#374), as these efforts will need to be tracked separately.

Follow-up to #367.
Closes #352.
Closes #373.

This commit adds support for the following 3.17.0 requests:

* `workspaceSymbol/resolve`
* `textDocument/prepareTypeHierarchy`
* `typeHierarchy/supertypes`
* `typeHierarchy/subtypes`
* `textDocument/inlineValue`
* `textDocument/inlayHint`
* `inlayHint/resolve`
This commit adds support for the following 3.17.0 requests:

* `window/showDocument` (actually from 3.16.0, just missed)
* `workspace/inlineValue/refresh`
* `workspace/inlayHint/refresh`
@ebkalderon ebkalderon self-assigned this Feb 28, 2023
@ebkalderon ebkalderon merged commit 9af8a4d into master Feb 28, 2023
@ebkalderon ebkalderon deleted the support-lsp-types-0.94.0 branch February 28, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release with lsp-types 0.94.0 support inlineValue method and Inlay Hint Request
1 participant