Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stucking wait mode caused by unscheduled workloads and disconnected agents variations #384

Open
wants to merge 26 commits into
base: main
Choose a base branch
from

Conversation

inf17101
Copy link
Contributor

@inf17101 inf17101 commented Sep 25, 2024

Issues: #320

The PR covers the following:

  • fix the stucking wait mode when pending initial workloads with disconnected agents are deleted
  • display the deleted pending initial workloads as removed properly in the wait list
  • fix the stucking wait mode when workloads are updated to be unscheduled (empty agent name) and vice versa
  • fix the stucking wait mode when unscheduled workloads are deleted and display them properly as removed in the wait list
  • fixing the Ankaios server sending a removed execution state when a pending initial workload is deleted and its agent is disconnected
  • fix the stucking wait mode when a workload is created and during the creation the agent has been disconnected
  • fix the stucking wait mode when a workload is scheduled for deletion on the runtime and the agent is disconnected during the delete operation
  • fix a gap in the ank get workload swdd requirements by creating a new swdd for not described functionality when constructing the list of workloads
  • creating new swdds or changing existing swdds: here I have tried to keep the amount of requirements in the cli at a minimum, can be discussed in the review if it is enough or if we need to split them a little bit more.

Definition of Done

The PR shall be merged only if all items mentioned in CONTRIBUTING.md have been followed. In case an item is not applicable as described, please provide a short explanation in the description.

@inf17101 inf17101 changed the title 320 fix stucking wait list Fix stucking wait mode upon updates/deletion of workloads with disconnected agents and unscheduled workloads variations Sep 25, 2024
@inf17101 inf17101 changed the title Fix stucking wait mode upon updates/deletion of workloads with disconnected agents and unscheduled workloads variations Fix stucking wait mode caused by unscheduled workloads and disconnected agents variations Sep 25, 2024
@inf17101
Copy link
Contributor Author

inf17101 commented Sep 27, 2024

@krucod3: Do you think we need to change precondition for the following swdds after fixing the gap in ank get workloads?:

  • swdd~cli-shall-sort-list-of-workloads~1
  • swdd~cli-shall-filter-list-of-workloads~1
  • swdd~cli-shall-present-list-of-workloads~1

to point out more that sorting, filtering and so on is done after the CLI has created the initial list of workloads with their runtime names based on the current CompleteState? This is then closer to the code.

Since the CLI does not receive a list from the server directly, which can be sorted, filtered and so on. Furthermore, it processes the CompleteState converts it into a list of workloads with inserting their corresponding runtime names and then this new list is sorted, filtered and presented...

@inf17101 inf17101 self-assigned this Sep 27, 2024
@inf17101 inf17101 added bug Something isn't working. Issue will appear in the change log "Bug Fixes" ready for review labels Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. Issue will appear in the change log "Bug Fixes" ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant