Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace the project name "Chariott" in code and package names, with the component name "intent brokering" #251

Merged
merged 15 commits into from
Jan 29, 2024
Merged

Replace the project name "Chariott" in code and package names, with the component name "intent brokering" #251

merged 15 commits into from
Jan 29, 2024

Conversation

ladatz
Copy link
Contributor

@ladatz ladatz commented Jan 24, 2024 •
edited
Loading

Closes #149

Motivation and Context

Chariott is the project name. This PR removes "Chariott" as the naming of components, services, etc. from code. This helps to clarify that the Chariott project provides multiple components, including the Service Discovery service and the Intent Brokering service. These are two services which work independently from one another, and are not integrated in any way.

Description

  • Replace the name "chariott" with intent brokering, intent brokering service, and "intent", depending on the context, in all code, documentation, and examples.
  • Note: diagrams have not been updated yet and will be in a later PR, as there is an issue with the workflow that needs to be addressed

@ladatz ladatz marked this pull request as ready for review January 26, 2024 18:25
@ladatz ladatz changed the title First step of changing from chariott -> intent brokering in the code Remove the project name "Chariott" from code and package names, use intent brokering (component name) instead Jan 26, 2024
@ladatz ladatz changed the title Remove the project name "Chariott" from code and package names, use intent brokering (component name) instead Replace the project name "Chariott" in code and package names, to the component name "intent brokering" instead Jan 26, 2024
@ladatz ladatz changed the title Replace the project name "Chariott" in code and package names, to the component name "intent brokering" instead Replace the project name "Chariott" in code and package names, with the component name "intent brokering" Jan 26, 2024
ashbeitz
ashbeitz approved these changes Jan 26, 2024
View reviewed changes
Copy link

@ashbeitz ashbeitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

devkelley
devkelley reviewed Jan 26, 2024
View reviewed changes
Dockerfile.intent_brokering Outdated Show resolved Hide resolved
Dockerfile.intent_brokering Show resolved Hide resolved
docs/design/intent_brokering_design.md Outdated Show resolved Hide resolved
intent_brokering/README.md Outdated Show resolved Hide resolved
intent_brokering/common/src/streaming_ess.rs Outdated Show resolved Hide resolved
intent_brokering/tools/charc.md Outdated Show resolved Hide resolved
intent_brokering/tools/charc.md Outdated Show resolved Hide resolved
intent_brokering/tools/charc.md Outdated Show resolved Hide resolved
intent_brokering/tools/charc.md Outdated Show resolved Hide resolved
intent_brokering/tools/charc.md Outdated Show resolved Hide resolved
@ladatz ladatz merged commit 0fb0bcc into main Jan 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashbeitz ashbeitz ashbeitz approved these changes

@devkelley devkelley devkelley approved these changes

@jorchiu jorchiu jorchiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PBI] Evaluate removing "chariott" project name from package names, code etc.
4 participants
@ladatz @ashbeitz @devkelley @jorchiu