Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getWorkspaceConditions method #1196

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: getWorkspaceConditions method #1196

merged 1 commit into from
Sep 23, 2024

Conversation

olexii4
Copy link
Contributor

@olexii4 olexii4 commented Sep 19, 2024

What does this PR do?

Fix getWorkspaceConditions method.

Screenshot/screencast of this PR

Знімок екрана 2024-09-16 о 14 41 29

Знімок екрана 2024-09-16 о 14 41 07

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-6587

Is it tested? How?

  1. Deploy Eclipse-Che with the image from this PR.
  2. Open Create Workspace page on the dashboard.
  3. Put https://raw.githubusercontent.com/dmytro-ndp/devfile-with-typo/main/devfile.yaml factory into Git repo URL.
  4. Click Create & Open.
  5. The workspace should fails with an error ImagePullBackOff.
  6. Open a new tab with the swagger link {CHE-Server}/dashboard/api/swagger.
  7. And apply the patch to fix the target devvorkspace:
[
 {
   "op": "replace",
   "path": "/spec/template/components/0/container/image",
   "value": "quay.io/devfile/universal-developer-image:ubi8-latest"
  }
]
  1. Open Starting workspace page and click Restart
  2. The target workspace should restart without any warnings or errors.

Release Notes

Docs PR

@che-bot
Copy link
Contributor

che-bot commented Sep 19, 2024

Click here to review and test in web IDE: Contribute

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.47%. Comparing base (4f1bf61) to head (0ca10f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1196      +/-   ##
==========================================
- Coverage   91.48%   91.47%   -0.02%     
==========================================
  Files         440      440              
  Lines       45540    45538       -2     
  Branches     3059     3069      +10     
==========================================
- Hits        41663    41656       -7     
- Misses       3877     3882       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Oleksii Orel <oorel@redhat.com>
Copy link

Docker image build succeeded: quay.io/eclipse/che-dashboard:pr-1196

kubectl patch command
kubectl patch -n eclipse-che "checluster/eclipse-che" --type=json -p="[{"op": "replace", "path": "/spec/components/dashboard/deployment", "value": {containers: [{image: "quay.io/eclipse/che-dashboard:pr-1196", name: che-dashboard}]}}]"

@olexii4 olexii4 marked this pull request as ready for review September 23, 2024 13:13
Copy link

openshift-ci bot commented Sep 23, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: akurinnoy, ibuziuk, olexii4

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ibuziuk
Copy link
Member

ibuziuk commented Sep 23, 2024

@olexii4 please cherry-pick to 7.92.x

@olexii4 olexii4 merged commit 83c505c into main Sep 23, 2024
19 of 21 checks passed
@olexii4 olexii4 deleted the fix_1188 branch September 23, 2024 13:51
@devstudio-release
Copy link

Build 3.17 :: dashboard_3.x/550: Console, Changes, Git Data

@devstudio-release
Copy link

@devstudio-release
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants