Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proc_setting-up-the-microsoft-azure-devops-services-oauth-app.… #2623

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

satyamburhade
Copy link

…adoc

docs: Adding a step to Authorize access to the application with OAuth 2.0

What does this pull request change?

What issues does this pull request fix or reference?

Specify the version of the product this pull request applies to

Pull Request checklist

The author and the reviewers validate the content of this pull request with the following checklist, in addition to the automated tests.

  • Any procedure:
    • Successfully tested.
  • Any page or link rename:
  • Builds on Eclipse Che hosted by Red Hat.
  • the Validate language on files added or modified step reports no vale warnings.

…adoc

docs: Adding a step to Authorize access to the application with OAuth 2.0
@github-actions
Copy link

github-actions bot commented Jul 12, 2023

Click here to review and test in web IDE: Contribute

@github-actions
Copy link

github-actions bot commented Jul 12, 2023

⚡️ Deploying pull request preview...

@ibuziuk
Copy link
Member

ibuziuk commented Jul 12, 2023

@satyamburhade thank you for the contribution, please sign the https://www.eclipse.org/legal/ECA.php so that we could merge the PR

…osoft-azure-devops-services-oauth-app.adoc

Co-authored-by: Ilya Buziuk <ilyabuziuk@gmail.com>
@satyamburhade
Copy link
Author

@ibuziuk I've signed the ECA
Screenshot from 2023-07-12 22-34-10

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satyamburhade Actually, I'm not sure we should change the link title since https://learn.microsoft.com/en-us/azure/devops/integrate/get-started/authentication/oauth?view=azure-devops has the "Authorize access to REST APIs with OAuth 2.0" which is already set correctly in the doc. wdyt?

Copy link
Contributor

@deerskindoll deerskindoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@ibuziuk ibuziuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satyamburhade Actually, I'm not sure we should change the link title since https://learn.microsoft.com/en-us/azure/devops/integrate/get-started/authentication/oauth?view=azure-devops has the "Authorize access to REST APIs with OAuth 2.0" which is already set correctly in the doc. wdyt?

Copy link
Author

@satyamburhade satyamburhade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keeping the link in Additional resources and adding a step

@ibuziuk
Copy link
Member

ibuziuk commented Jul 18, 2023

@tolusha @vinokurig folks, could you please review? Not sure if this step is required

@@ -46,6 +46,8 @@ $ echo -n '__<microsoft_azure_devops_services_oauth_app_id>__' | base64
$ echo -n '__<microsoft_azure_devops_services_oauth_client_secret>__' | base64
----

. Make sure to authorize the application when Azure DevOps Services presents the authorization approval page to a user.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@satyamburhade
Actually I didn't face anything that requires approval.
Could you show some screenshots for better understanding?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got what you meant.

Copy link
Contributor

@vinokurig vinokurig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is NOT related to the Admin, see #2624

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants