Backport to 3.0.x: Succeed TriggerControllerFuture.cancel when inner future is done #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… done
The inner future (currentFuture) is used for repeating execution and its
state is set to NORMAL/[Completed normally] after each cycle. The
TriggerControllerFuture.cancel should return true even if this inner
future is done.
|
What does it mean: FISH-6556? |
I think it was some internal @aubi's task under which he contributed the original PR master, targeting 3.1.0. This is a backport of that PR to 3.0.x. I'll update the title accordingly. |
OndroMih
changed the title
OndroMih
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of
The inner future (currentFuture) is used for repeating execution and its state is set to NORMAL/[Completed normally] after each cycle. The TriggerControllerFuture.cancel should return true even if this inner future is done.