Skip to content

Commit

Permalink
GH #25039 Facelets in Console: Clean up
Browse files Browse the repository at this point in the history
Moved CDI producers into Admin Core, so that they can be reused by other modules and we avoid conflicts or implicit dependencies if multiple modules define the same producers or rely on beans produced by other modules.
  • Loading branch information
OndroMih committed Jul 11, 2024
1 parent 94ae8aa commit c0991e8
Show file tree
Hide file tree
Showing 12 changed files with 37 additions and 27 deletions.
2 changes: 1 addition & 1 deletion appserver/admingui/commandrecorder/pom.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright (c) 2010, 2021 Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2024 Contributors to the Eclipse Foundation
This program and the accompanying materials are made available under the
terms of the Eclipse Public License v. 2.0, which is available at
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright (c) 2009, 2018 Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2024 Contributors to the Eclipse Foundation
This program and the accompanying materials are made available under the
terms of the Eclipse Public License v. 2.0, which is available at
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
onFocus="window.status='$resource{i18n.masthead.restartStatusMsg}'; return true"
url="#{request.contextPath}/common/appServer/restart.jsf">
</sun:hyperlink>
"</span>
"</span>
<!afterCreate
includeIntegrations(type="org.glassfish.admingui:mastheadStatusArea" root="$this{component}");
/>
Expand Down
10 changes: 10 additions & 0 deletions appserver/admingui/core/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,16 @@
<name>Admin Console Core Jar</name>

<dependencies>
<dependency>
<groupId>jakarta.enterprise</groupId>
<artifactId>jakarta.enterprise.cdi-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>jakarta.security.enterprise</groupId>
<artifactId>jakarta.security.enterprise-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.glassfish.woodstock</groupId>
<artifactId>woodstock-webui-jsf</artifactId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
*/
package org.glassfish.commandrecorder.admingui.cdi;
package org.glassfish.admingui.cdi;

import jakarta.enterprise.context.ApplicationScoped;
import jakarta.enterprise.inject.Produces;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
*
* SPDX-License-Identifier: EPL-2.0 OR GPL-2.0 WITH Classpath-exception-2.0
*/
package org.glassfish.commandrecorder.admingui.cdi;
package org.glassfish.admingui.cdi;

import jakarta.enterprise.context.ApplicationScoped;
import jakarta.enterprise.inject.Produces;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023 Contributors to the Eclipse Foundation
* Copyright (c) 2024 Contributors to the Eclipse Foundation
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2023 Contributors to the Eclipse Foundation
* Copyright (c) 2024 Contributors to the Eclipse Foundation
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
/*
* Copyright (c) 2023 Contributors to the Eclipse Foundation
* Copyright (c) 2010, 2018 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2024 Contributors to the Eclipse Foundation
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
Expand Down
15 changes: 15 additions & 0 deletions appserver/admingui/war/src/main/webapp/WEB-INF/faces-config.xml
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,21 @@
<name>admingui</name>
<application>
<view-handler>org.glassfish.admingui.common.AdminGuiViewHandler</view-handler>
<locale-config>
<default-locale>en</default-locale>
<supported-locale>de</supported-locale>
<supported-locale>sv</supported-locale>
<supported-locale>en_US</supported-locale>
<supported-locale>fr</supported-locale>
<supported-locale>ko</supported-locale>
<supported-locale>ja</supported-locale>
<supported-locale>zh_TW</supported-locale>
<supported-locale>zh_CN</supported-locale>
<supported-locale>es</supported-locale>
<supported-locale>it</supported-locale>
<supported-locale>pt_BR</supported-locale>
</locale-config>
<el-resolver>com.sun.webui.jsf.faces.UIComponentELResolver</el-resolver>
</application>
<factory>
<application-factory>org.glassfish.admingui.common.AdminGuiApplicationFactory</application-factory>
Expand Down
4 changes: 4 additions & 0 deletions appserver/admingui/war/src/main/webapp/WEB-INF/web.xml
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@
<servlet-name>FacesServlet</servlet-name>
<url-pattern>/html/*</url-pattern>
</servlet-mapping>
<servlet-mapping>
<servlet-name>FacesServlet</servlet-name>
<url-pattern>/faces/*</url-pattern>
</servlet-mapping>
<servlet-mapping>
<servlet-name>FacesServlet</servlet-name>
<url-pattern>*.xhtml</url-pattern>
Expand Down
18 changes: 0 additions & 18 deletions appserver/admingui/war/src/main/webapp/iframe.xhtml

This file was deleted.

0 comments on commit c0991e8

Please sign in to comment.