Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix syntax errors in documentation #23739

Closed
dmatej opened this issue Dec 11, 2021 · 0 comments · Fixed by #23741
Closed

Fix syntax errors in documentation #23739

dmatej opened this issue Dec 11, 2021 · 0 comments · Fixed by #23741
Assignees
@dmatej
Labels
Documentation In Progress
Milestone
7.0.0

Comments

@dmatej
Copy link
Contributor

dmatej commented Dec 11, 2021 •
edited
Loading

Effects:

  • When building in the docs directory, asciidoctor logs many warnings. Those warnings are pretty much correct.
  • And the worse thing: these errors force asciidoc to use some heuristic leading to huge stack and code cache requirements, the build is slow and produces broken PDF files.

Example from PDF:
image
@dmatej dmatej self-assigned this Dec 11, 2021
@dmatej dmatej added this to the 7.0.0 milestone Dec 11, 2021
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 11, 2021
@dmatej
Issue eclipse-ee4j#23739 Updated dependencies in docs
11e7887
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 11, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed broken asciidocs in add-on-component-d…
0deeaa4 
…evelopment
@dmatej dmatej linked a pull request Dec 11, 2021 that will close this issue
Issue 23739 Fixed documentation syntax, using only Asciidoctor, JBake removed #23741
Merged
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 13, 2021
@dmatej
Issue eclipse-ee4j#23739 Updated dependencies in docs
1121fc2
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 13, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed broken asciidocs in add-on-component-d…
9870250 
…evelopment
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 13, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed broken asciidocs in add-on-component-d…
f424de7 
…evelopment
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 14, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed broken asciidocs in add-on-component-d…
ea3269f 
…evelopment
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 14, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed broken asciidocs in administration-guide
20b0bf9
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 14, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed imagesDirt configuration
fb68f27
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 14, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed imagesDir configuration, added source …
d5d54b4 
…highlighter

Signed-off-by: David Matějček <dmatej@seznam.cz>
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 14, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed broken lists in administration-guide
55e48a9
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 15, 2021
@dmatej
Issue eclipse-ee4j#23739 Updated dependencies in docs
61c7728
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 15, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed broken asciidocs in add-on-component-d…
b97f17f 
…evelopment
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 15, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed broken asciidocs in administration-guide
5e133a5
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 15, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed imagesDir configuration, added source …
58dec7b 
…highlighter

Signed-off-by: David Matějček <dmatej@seznam.cz>
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 15, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed broken lists in administration-guide
a9dc364
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 15, 2021
@dmatej
Issue eclipse-ee4j#23739 Notes in administration-guide - standard syntax
219ef57
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 15, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in application-deployment
187e37a
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 15, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in application-development
a5738c0
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 15, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in deployment-planning-guide
9e97561
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 16, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in embedded-server-guide
bae35b8
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 16, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in error-messages-reference
d4730e7 
- this pdf seems quite worthless to me ...
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 16, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in ha-administration-guide
07d1264
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 17, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in ha-administration-guide
639c511
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 17, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in installation-guide
98c7f64
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 17, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in performance-tuning-guide
dd29f5e
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in deployment-planning-guide
b58a1db
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in embedded-server-guide
03b2211
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in error-messages-reference
05d733b 
- this pdf seems quite worthless to me ...
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in ha-administration-guide
80eceb3
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in installation-guide
18d271b
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in performance-tuning-guide
2032ff3
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in quick-start-guide
e22e687
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in reference-manual
17fd461
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 toclevel is configurable
8d36913
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in release-notes
ceae480
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in security-guide
7a39e79
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in troubleshooting-guide
5d1e8d8
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixes in upgrade-guide
83c0196
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Smaller fixes
f2ef99a
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 glassfish3 to glassfish7
65f2092
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Versions 4, 5, 5.1, 6.1 to 7
cdb551e
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Added NOT regards to compatibility with prev…
8d7df88 
…ious releases
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed title
af6506b
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed resolving product name variable both i…
7b4e697 
…n html and pdf
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Updated links, synced preface.adoc, replaced…
9d73d04 
… Java EE to Jakarta EE
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Using safer syntax for headers
dbccabf 
- previous was extremely sensitive to the length of the test above
- this change was done by a set of regular expressions, I hope I did not
  miss something.
- I am committing also toc files as they are helpful to detect any broken
  chapter header in diff
- plus: this syntax is colored by the Eclipse Editor
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed generating html including toc
b477ce4 
- jbake maven plugin not required any more
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 jbake is out, now we use just asciidoctor - …
7788360 
…structural changes
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Revided JDK mentions
275e430 
- deleted several block which are not valid any more
- repklaced 6/8 by 11, however left 6 where it would mean rewriting the chapter
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 20, 2021
@dmatej
Issue eclipse-ee4j#23739 Using productName
6c58c14
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 21, 2021
@dmatej
Issue eclipse-ee4j#23739 Fixed html filename
1e9c9ec
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 21, 2021
@dmatej
Issue eclipse-ee4j#23739 Updated website links
a62abb1 
- as I replaced jbake dependency by asciidoctor, the documentation html files
  changed structure and names. This commit reflects that.
dmatej added a commit to dmatej/glassfish that referenced this issue Dec 22, 2021
@dmatej
Issue eclipse-ee4j#23739 Updated html links
2a4fd86
arjantijms added a commit that referenced this issue Dec 22, 2021
@arjantijms
Merge pull request #23746 from dmatej/issue-23739-asciidoc-fixes
65be725 
Issue #23739 Updated website links
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmatej dmatej

Labels
Documentation In Progress
Projects
None yet
Milestone
7.0.0
Development

Successfully merging a pull request may close this issue.

Issue 23739 Fixed documentation syntax, using only Asciidoctor, JBake removed dmatej/glassfish
1 participant
@dmatej