Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do extra work to integrate Weld 5 #23872

Closed
arjantijms opened this issue Mar 29, 2022 · 5 comments
Closed

Do extra work to integrate Weld 5 #23872

arjantijms opened this issue Mar 29, 2022 · 5 comments
Milestone

Comments

@arjantijms
Copy link
Contributor

Weld 5 has changed things so that extra work is needed to integrate it.

See http://weld.cdi-spec.org/news/2022/01/24/weld-500Beta1/ and

https://www.eclipse.org/lists/cdi-dev/msg00573.html

@gurunrao
Copy link
Contributor

gurunrao commented Apr 27, 2022

CDI TCK with GF7 has 102 failures CI run link .
BV TCK with GF 7 has 165 failures CI run link.

@arjantijms
Copy link
Contributor Author

arjantijms commented May 22, 2022

@gurunrao

The latest numbers with updated GF and updated CDI API are:

Tests run: 1863, Failures: 54, Errors: 0, Skipped: 32

Additionally, the existing TCK porting kit is very large. It's possible to run the CDI TCK with much less code. See https://github.com/eclipse-ee4j/glassfish/tree/master/appserver/tests/tck/cdi

@dmatej
Copy link
Contributor

dmatej commented May 22, 2022

Example:
mvn clean install -Pstaging,tck -pl :glassfish-external-tck-cdi -Dtest=**/full/extensions/lifecycle/**
This passed.

Or another:
mvn clean install -Pstaging,tck -pl :glassfish-external-tck-cdi -Dtest=**/full/extensions/**
This has one failure, but what is the cause and how to fix it?

[ERROR]   BuildCompatibleExtensionSmokeTest>Arquillian.run:138->testExtensionsCanCoexist:41 expected [0] but found [5]
[INFO]
[ERROR] Tests run: 281, Failures: 1, Errors: 0, Skipped: 0

Seems extensions now cannot coexist. Is it a bug in GF or in Weld?

@dmatej dmatej removed their assignment May 23, 2022
@dmatej
Copy link
Contributor

dmatej commented Aug 1, 2022

Can this be already closed, or everything is done now?

@arjantijms
Copy link
Contributor Author

arjantijms commented Aug 1, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants