Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 23616 Fixed generators on jdk11 + tests #23621

Merged
merged 10 commits into from
Oct 2, 2021
Merged

Issue 23616 Fixed generators on jdk11 + tests #23621

merged 10 commits into from
Oct 2, 2021

Commits on Sep 27, 2021

  1. Tests for eclipse-ee4j#23616 and eclipse-ee4j#23606 Reproducers 

    - JMH test to reproduce race condition (already fixed)
- tests for generator issues
    @dmatej
    dmatej committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    09f7657 View commit details
    Browse the repository at this point in the history

  2. Syntax cleanups before eclipse-ee4j#23616 

    - imports, enhanced loops, finals, curly braces, generics
    @dmatej
    dmatej committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    c5bc181 View commit details
    Browse the repository at this point in the history

  3. Fixed eclipse-ee4j#23616 Changed generateSEI api, the error is not po… 

    …ssible any more

- I removed the test too, because now it is already covered by the benchmark
    @dmatej
    dmatej committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    a9b611a View commit details
    Browse the repository at this point in the history

  4. Fixed eclipse-ee4j#23616 loadGeneratedGenericEJBHomeClass fixed 

    - now uses GenericHomeGenerator as an anchor instead of EJBUtils
    @dmatej
    dmatej committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    0971323 View commit details
    Browse the repository at this point in the history

  5. Fixed eclipse-ee4j#23616 generateAndLoad cleanup 

    - stop using deprecated methods
- synchronization moved to method level and loading to one single caller which
  didn't do that yet -> reduced duplicit actions
    @dmatej
    dmatej committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    be45bc4 View commit details
    Browse the repository at this point in the history

  6. Fixed eclipse-ee4j#23616 by refactoring 

    - cleanup around leaky api of generateAndLoad which relied on consistency of
  it's parameters
- the anchor class was moved to the generator to keep JDK rules
- removeRedundantMethods was and is slow -> TODO: optimize + test
- ServiceInterfaceGenerator changed output class name and package, because
  original addition of jaxws.internal is forbidden in JDK11+
- tests were enhanced to be able to compare loading of cached classes.
    @dmatej
    dmatej committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    03c2dd7 View commit details
    Browse the repository at this point in the history

  7. Fixed eclipse-ee4j#23616 Added suppressions also for generated code i… 

    …n tests
    @dmatej
    dmatej committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    8f038f9 View commit details
    Browse the repository at this point in the history

  8. Issue eclipse-ee4j#23616 Updated dependencies, jmh added to dependenc… 

    …y management
    @dmatej
    dmatej committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    56db429 View commit details
    Browse the repository at this point in the history

  9. Issue eclipse-ee4j#23616 Reduced cyclic dependencies between EJBUtils… 

    … and others
    @dmatej
    dmatej committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    edd897c View commit details
    Browse the repository at this point in the history

  10. Issue eclipse-ee4j#23616 Fixed issue with generating proxies using ge… 

    …nerated classes

- we have to use deprecated methods yet for a while ...
    @dmatej
    dmatej committed Sep 27, 2021
    Configuration menu
    Copy the full SHA
    e9a30b8 View commit details
    Browse the repository at this point in the history