Fix #21841 Setting non-integer value to a config bean attribute with @Min or @Max and without dataType=Integer.class locks the config bean #23693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These properties are validated in JdbcConnectionPoolValidator$isValid() but the validation method calls Integer.parseInt() without checking the value type and throws NumberFormatException if the value is not Integer.
And, the caller org.jvnet.hk2.config.ConfigSupport$apply() does not catch the NumberFormatException in its own transaction.
That causes this issue.
On the other hand, org.glassfish.jdbc.config.JdbcConnectionPool has the annotation argument to avoid to set the invalid type value.
I think using this annotation argument is easer to deal with this issue.
Signed-off-by: 11rx4f ryosuke.okada@fujitsu.com