Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #23700 Add properties file to ejb-full-container #23701

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

kaido207
Copy link
Contributor

@kaido207 kaido207 commented Nov 5, 2021

There is no properties file about the message keys in appserver/ejb/ejb-full-container, so the logger in ejb-full-container cannot print messages correctly.

These properties are copied from appserver/ejb/ejb-container.

Signed-off-by: kaido207 kaido.hiroki@fujitsu.com

Signed-off-by: kaido207 <kaido.hiroki@fujitsu.com>
@glassfish-bot
Copy link
Contributor

Can one of the admins verify this patch?

@hs536 hs536 added the bug Something isn't working label Nov 8, 2021
Copy link
Contributor

@arjantijms arjantijms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, which the usual caveat that at some point we may need to revise the logging entirely.

@arjantijms arjantijms merged commit 6d62d93 into eclipse-ee4j:master Nov 9, 2021
@arjantijms arjantijms added this to the 6.2.3 milestone Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The message keys are printed as is in the server.log when an ejb timer service is deployed.
4 participants