Integrate Faces 4.0.0-M3 #23823
Merged
Integrate Faces 4.0.0-M3 #23823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
arjantijms
added
component upgrade
dmatej
approved these changes
Feb 21, 2022
hs536
approved these changes
Feb 21, 2022
|
Breaks CDI for some reason, Arjan knows about it. |
Yes, I/we made a mistake in the initialiser code, which is a somewhat confusing thing where annotations that Mojarra uses to determine whether it needs to activate itself are mixed with the set of all annotations that Mojarra uses. Among them is "@resource", which is used by Mojarra but should not activate it. All the tests that fail contain "@resource" annotations without any CDI activation. As Faces needs CDI to be present, this it what fails. |
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Arjan Tijms arjan.tijms@gmail.com