Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed nightly and weekly builds which use gfbuild.sh #23824

Merged
merged 1 commit into from
Feb 23, 2022
Merged

Fixed nightly and weekly builds which use gfbuild.sh #23824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions gfbuild.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ dev_build(){
}

build_re_dev(){
if [ -f "${WORKSPACE}/snapshots/pom.xml" ]; then
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this expects ${WORKSPACE} to be the root directory of the source repository, but Jenkins sets an environment variable with the same name to the job start directory, so this does not work as expected on Jenkins.

On the other hand, ${WORKSPACE} is not used by the Jenkins System, so I changed Jenkins settings a bit[*1]. but I still get different errors[*2]...
[*1] https://ci.eclipse.org/glassfish/view/GlassFish/job/glassfish_build-and-publish-to-eclipse-download/jobConfigHistory/showDiffFiles?timestamp1=2022-02-23_20-35-51&timestamp2=2022-02-23_20-40-26

  # Directory with GlassFish GH repo
+ WORKSPACE=${WORKSPACE}/glassfish-build
  cd glassfish-build
  git status

[*2] https://ci.eclipse.org/glassfish/view/GlassFish/job/glassfish_build-and-publish-to-eclipse-download/652/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably because jakarta.el-api-5.0.0-RC1.jar has not yet been published on Maven Central.

https://repo.eclipse.org/content/repositories/maven_central/jakarta/el/jakarta.el-api/5.0.0-RC1/

Copy link
Contributor Author

@dmatej dmatej Feb 24, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It tried to use even 5.0.0, not 5.0.0-RC1, probably the snapshot changed in between? Edit: nope. But was removed the staging repo dependency.
Could not find artifact jakarta.el:jakarta.el-api:jar:5.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems the Eclipse mirror is broken somehow ... and also the dependency on 5.0.0 instead on 5.0.0-RC1 is probably incorrect ... https://repo1.maven.org/maven2/jakarta/el/jakarta.el-api/5.0.0-RC1/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, seems the Eclipse mirror is broken somehow ... and also the dependency on 5.0.0 instead on 5.0.0-RC1 is probably incorrect ... https://repo1.maven.org/maven2/jakarta/el/jakarta.el-api/5.0.0-RC1/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... and the staging repo was removed from the hibernate-validator ...
https://jakarta.oss.sonatype.org/content/repositories/staging/jakarta/el/jakarta.el-api/5.0.0/

mvn clean install -T2C -f "${WORKSPACE}/snapshots/pom.xml" ${MVN_EXTRA}
fi
dev_build
archive_bundles
merge_junits
Expand Down