Fixed nightly and weekly builds which use gfbuild.sh

[pzygielo]

Tested locally

This merges

• Fixed nightly and weekly builds which use gfbuild.sh #23824
• Add settings.xml for snapshots #23829

for https://ci.eclipse.org/glassfish/view/GlassFish/job/glassfish_build-and-publish-to-eclipse-download/ to continue with next build steps.
Per its https://ci.eclipse.org/glassfish/view/GlassFish/job/glassfish_build-and-publish-to-eclipse-download/656/console - it is using

bash -xe ./gfbuild.sh build_re_dev

so this might help.

[pzygielo]

So this working

glassfish/Jenkinsfile

Lines 265 to 266 in a85f4d2

	# temporary build of external snapshot dependencies
	mvn clean install -f ./snapshots/pom.xml

(without settings.xml used)
regardless of glassfish_build-and-publish-to-eclipse-download failing, just confirms to me that

glassfish/Jenkinsfile

Lines 164 to 165 in a85f4d2

	- name: maven-repo-shared-storage
	mountPath: /home/jenkins/.m2/repository

can be at least dangerously misleading as for build result.
Re-staged artifacts (as I verified also in #23830) are not refreshed.

I just hope that for release build cache is not used, but this https://ci.eclipse.org/glassfish/view/GlassFish/job/glassfish_1-build-and-stage/25/consoleText

   - mountPath: "/home/jenkins/.m2/repository"
     name: "volume-3"
     readOnly: false

is not reassuring +

• https://ci.eclipse.org/glassfish/job/glassfish-purge-maven-cache/, 2019-01-20
• https://ci.eclipse.org/glassfish/job/prune-maven-cache/, 2021-03-23

with several releases since.

[arjantijms]

Re-staged artifacts (as I verified also in #23830) are not refreshed.

That's indeed a defect. Just the other day I encountered the same issue with re-staging a Mojarra artefact.

Perhaps we need to add the prune-maven-cache functionality to the 1_stage job as an option, and mention it should be enabled at least for releases going to central.

[arjantijms]

lgtm