Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Weld 5.0.0.SP1 #23925

Merged
merged 2 commits into from
May 4, 2022
Merged

Integrate Weld 5.0.0.SP1 #23925

merged 2 commits into from
May 4, 2022

Conversation

arjantijms
Copy link
Contributor

Signed-off-by: Arjan Tijms arjan.tijms@gmail.com

@arjantijms
Integrate Weld 5.0.0.Final
349f54c 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@arjantijms arjantijms added component upgrade A component dependency has been upgraded ee10-component Jakarta EE 10 component labels May 1, 2022
@arjantijms arjantijms added this to the 7.0.0 milestone May 1, 2022
@arjantijms arjantijms requested a review from dmatej May 1, 2022 22:48
@arjantijms arjantijms self-assigned this May 1, 2022
dmatej
dmatej requested changes May 3, 2022
View reviewed changes
Copy link
Contributor

@dmatej dmatej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Communicating with the Weld team, seems we detected some error ...

@dmatej
Copy link
Contributor

dmatej commented May 4, 2022 •
edited
Loading

The error is fixed, now we have two options:

  • wait for Weld 5.0.1
  • build it and use snapshot.

@arjantijms
Copy link
Contributor Author

build it and use snapshot.

Let's try the snapshot first then. It will be a quick replace when 5.0.1 is released.

@arjantijms
Update to Weld 5.0.0.SP1
5835cf7 
Signed-off-by: Arjan Tijms <arjan.tijms@gmail.com>
@manovotn
Copy link

manovotn commented May 4, 2022

The release is in Central already - it is 5.0.0.SP1 (just the core artifact, API stays the same).
If you find any more issues, let me know. But hopefully, this should do the trick :-)

@pzygielo pzygielo changed the title Integrate Weld 5.0.0.Final Integrate Weld 5.0.0.SP1 May 4, 2022
@arjantijms
Copy link
Contributor Author

@manovotn thanks, the tests pass now!

@arjantijms arjantijms merged commit ab4e2d1 into eclipse-ee4j:master May 4, 2022
@arjantijms arjantijms deleted the weld500 branch May 4, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmatej dmatej dmatej approved these changes

@scottmarlow scottmarlow scottmarlow approved these changes

Assignees

@arjantijms arjantijms

Labels
component upgrade A component dependency has been upgraded ee10-component Jakarta EE 10 component
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@arjantijms @dmatej @manovotn @scottmarlow