Support scanning applibs

[arjantijms]

Refactoring first:

• Renaming variables
• Formatting
• Simplifying logic
• Etc

[arjantijms]

@anajosep what do you think? Is this a good approach? @senivam any opinion? This touches the deployer code.

[gurunrao]

@arjantijms, IMO we can add following details for wider review of the PR:

• changes proposed in this pull request(or issue (link) that is solved with pull request or link to mailing list discussion thread)
• PR tested(like CI link or logs)

[dmatej]

Just a question - is there some fix I did not notice or is it really just cleanup? (if not, the title is a bit misleading)

[arjantijms]

The fix / change is in the second commit. It adds the libraries identified by extension-list to the collection of libraries returned.

The first commit is only cleanup.

[arjantijms]

@gurunrao thanks for your suggestion, you are right. This fixes the CDI TCK test for EarInstalledLibs which has 3 variants. It's the test where the CDI TCK wants the integrator / test runner to put the ext-cdi-Lib in a server extension folder (in gf this is domains/domain1/Lib/applied). The test then checks that the beans inside this jar are scanned.

Ultimately the change is small (2nd commit). The first commit represents the code I had to read and study to ultimately be able to make that small change.

[dmatej]

The fix / change is in the second commit. It adds the libraries identified by extension-list to the collection of libraries returned.

The first commit is only cleanup.

Oh, yeah, mea culpa, I should take a look on the list of commits, now I understand. Yeah, seems logical to me.