Cleanups #23973
Merged
Cleanups #23973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Jun 7, 2022
•
dmatej
commented
- resources, formatting, loops, javadoc, ...
- classloaders, containers, archives, ...
dmatej
changed the title
- generics, stringbuffers, formatting
- generics, stringbuffers, formatting, cycles
- generics, stringbuffers, formatting, deprecated methods - bit of optimization - debug removed (unused) - delegate is true by default, synced - logic around isDelegateFirstResource simplified (probably will be revisited for Faces TCK)
- Eclipse warnings are correct technically, but in the real world args[0] is probably always ok in those places.
- the Vector of Strings was used just to check for name collisions, set is better
- before this PR it was commented out - it shouldn't be here at all because it was closing what wasn't open by this method However this package is full of side-effects and should be reimplemented.
- Eclipse warnings are correct technically, but in the real world args[0] is probably always ok in those places. - EJBLocalHomeInvocationHandler and EJBHomeInvocationHandler are very similar
- caused in 9076920
dmatej
force-pushed
the
cleanups-resources-formatting
branch
from
f3d7b60
to
2978b54
Compare
arjantijms
approved these changes
Jun 8, 2022
hs536
reviewed
Jun 27, 2022
appserver/web/war-util/src/main/java/org/glassfish/web/loader/WebappClassLoader.java
Show resolved
Hide resolved
hs536
reviewed
Jun 28, 2022
appserver/web/war-util/src/main/java/org/glassfish/web/loader/WebappClassLoader.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.