Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Updated and reactivated Krazo for MVC 2.0 support"" #24011

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Revert "Revert "Updated and reactivated Krazo for MVC 2.0 support"" #24011

merged 1 commit into from
Jun 21, 2022

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Jun 21, 2022 •
edited
Loading

This reverts commit 8aa0f20.

Things changed, now GF passed CDI even with this change.

See #23988 for the original PR

@dmatej
Revert "Revert "Updated and reactivated Krazo for MVC 2.0 support""
210f6f2 
This reverts commit 8aa0f20.

# Conflicts:
#	appserver/pom.xml
@dmatej dmatej added this to the 7.0.0 milestone Jun 21, 2022
@chkal
Copy link
Contributor

chkal commented Jun 21, 2022

@dmatej Thanks a lot. But I think you also need to revert the changes to the spec and Krazo versions from here:

8aa0f20

See the changes in appserver/pom.xml.

@dmatej
Copy link
Contributor Author

dmatej commented Jun 21, 2022

@dmatej Thanks a lot. But I think you also need to revert the changes to the spec and Krazo versions from here:

8aa0f20

See the changes in appserver/pom.xml.

Those were superseeded by this change: 85749d2 , isn't it alright? I tried the CDI with this.

OndroMih
OndroMih approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@OndroMih OndroMih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK

@dmatej dmatej merged commit 3cde738 into eclipse-ee4j:master Jun 21, 2022
@dmatej dmatej deleted the mvc-api-is-back branch June 21, 2022 22:41
@dmatej dmatej mentioned this pull request Jun 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OndroMih OndroMih OndroMih approved these changes

@arjantijms arjantijms arjantijms approved these changes

@chkal chkal Awaiting requested review from chkal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dmatej @chkal @OndroMih @arjantijms