- Target: make unit tests possible

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- originally it required an exact match of the parameter's type
- now it first tries the exact match, when no such method exists it tries to
  find any compatible method of the same name.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- instead of abstract methods moving their implementation as a default impl
- It is quite complicated work affecting many places, so I will do rather
  smaller steps.
- about generics - the coverage is not perfect because of cyclic dependencies

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- all classes used the same method.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- broke connectors in tests; maybe it wouldn't be an issue for user, but I am
  not sure with that. I will find safer path.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- default implementations
- EjbApplicationExceptionInfo

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- Issue: I tried to use mocking, but I have found that it doesn't work well and
  even if, it would not cover too much of the implementation.
- dol and ejb-container have too many relations, in fact the abstraction was
  unusable and worthless (and even undocumented).
  - I can create mocks for interfaces but I can't use them for validator.
  - I can create half-initialized mock of the abstract class, but it throws
    exceptions which take too much time to investigate and finally I find
    that the issue is the mock, not the code I wanted to test.
  - Same would apply for custom implementations (like is the only one,
    ejb-container) - too much details matter.
- In practice: dol should have much better API, OR all descriptors and nodes
  whould move to DOL. They can be extended and used in ejb-container, but must
  have some basic consistent meaningful implementation.
- So I do some basic steps forward now.
- Final result: test covering bug we have noticed in logs + the fix
  not breaking anything else. Side effect result: easier future changes.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- it was already checked for null

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- This is safe as there is only one child of this abstract class

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- Unused methods removed
- Used methods documented (at least minimal notes)
- Deprecated XML nodes from GF 3.1 marked as deprecated and removed code
  which used them but was worthless. Now they should be just tolerated.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

…tion

- one of intermediate steps - moving methods

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- validators cover possible issues just partially
- better break deploy asap with more helpful info, especially when it is about
  glassfish issues.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- broken in recent commit of the same PR
- also fixed some logs and formatting

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- most of issues were more visible when I caused some inconsistency
- the commit is unfortunately huge, but necessary
- the architecture of the DOL is broken, always was - depends on reflection
  across modules and packages

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- Fixes the issue when DOL used nulls because singletons weren't found in HK2
- Affected appclient, tests, validations, processing descriptors, etc.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- seen when deploying broken CargoTracker

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>

- foreach, avoiding for-keys-find-value, Vector replaced by ArrayList
- formatting, generics, javadocs

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>