Cleanups in connectors logging #24361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dmatej
commented
Mar 28, 2023
•
dmatej
commented
- some messages were broken
- some causes were lost
- several logs were redundant
- fixed some javadocs
- these changes were done locally when I was working on Cargotracker discoveries part one #24335 and Refactoring around WebBundleDescriptor and EjbBundleDescriptor #24337
- 08d7fc5 is rather trivial, I wasn't sure if it cannot lead to negative pool size or size higher than max. Now it is covered by a unit test.
hs536
reviewed
Mar 29, 2023
...s-runtime/src/main/java/com/sun/enterprise/resource/allocator/LocalTxConnectorAllocator.java
Show resolved
Hide resolved
dmatej
commented
Apr 9, 2023
...nnectors-runtime/src/main/java/com/sun/enterprise/resource/allocator/ConnectorAllocator.java
Show resolved
Hide resolved
- some messages were broken - some causes were lost - several logs were redundant - fixed some javadocs Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- obsoleted and deprecated code Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- new PoolSize class with atomic operations + unit test - guaranteed that we cannot go under zero - guaranteed that we will not provide more than maxPoolSize Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- createResource is called just from ConnectionPool where is the exception processed too. Warning will be logged for each failure there, until retries exceed configured count of attempts. Then instead of warning it will throw an exception. - Removed also i18n properties, fixed messages, unused dumpPoolStatus Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- this package should get more attention Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- Funny trap I made for myself. - Integration tests detected the bug (jdbc_all) Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
hs536
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.