Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master into 8.0 #24904

Merged
merged 56 commits into from
Apr 17, 2024
Merged

Merge master into 8.0 #24904

merged 56 commits into from
Apr 17, 2024

Conversation

arjantijms
Copy link
Contributor

No description provided.

escay and others added 30 commits March 27, 2024 14:58
…better max pool

size logic.

Add lock, add notifyWaitingThreads call for better max pool size logic.
No longer getResources while the pool is being resized. And inform
waiting threads when resources are marked as failed.
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
…ant equals

- Note that the equals method is not symmetric here
- Exousia uses Set.contains -> equals to check the authorization.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- throws an exception if it was not possible to delete some files.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- The file is owned by the domain, not by the application and not by the test.
- The server will notice that the file vanished at some point in time, but we
  cannot rely on that.
- Another reliable solution is to stop-domain - delete lib file - start-domain
- Also it is a bad practice to use the same library name for different
  contents.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…better max pool

size logic. Fix incorrect javadoc.
Fixed JmacHttpsTest - certificate authentication
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
Added staging repo to runtests.sh + archiving rotated server.log files on jenkins
Fixes eclipse-ee4j#23483 Add lock, add notifyWaitingThreads call for better max pool size logic.
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
…ven_plugin_8_0_2

Integrate Maven Git Commit Id plugin 8.0.2
…lugin_3_13_0

Integrate Maven Compiler plugin 3.13.0
…ugin_3_6_3

Integrate Maven Javadoc plugin 3.6.3
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
arjantijms and others added 26 commits April 9, 2024 14:40
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
…lugin_2_16_2

Update Versions Maven plugin to 2.16.2
…xrefs

Fixes cross-references in Administration Guide
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Update Jakarta RESTful Web Services TCK to 3.1.5
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
…1_3_1

Integrate JBoss Class File Writer 1.3.1.Final
Signed-off-by: Alexander Pinčuk <alexander.v.pinchuk@gmail.com>
Signed-off-by: Arjan Tijms <arjan.tijms@omnifish.ee>
@@ -867,6 +868,7 @@
<artifactId>maven-failsafe-plugin</artifactId>
<version>3.2.5</version>
<configuration>
<rerunFailingTestsCount>3</rerunFailingTestsCount>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this shitty thing again? That means waiting for the build forever ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I often get a failure, and then I need to manually re-run it. Better to have it automated. It warns when the test is flakey.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, in Jenkins same test failed four times in a row. Something wrong in the connection pool...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The weird thing is that locally it can just build the branch. I've to investigate what I'm doing wrong. Probably something silly...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It always fails on Jenkins since the previous PR. I think you should not merge it and start screaming that something is wrong with master ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flaky test = something is broken, this is an attempt to hide it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have found another issue with java home, I have to fix it first, then I will take a look what is wrong with pools. But I really oppose this change - Jenkins is here to report every issue and keep us safe, not to "make it green, anyhow".

@arjantijms arjantijms merged commit 4f09f4c into eclipse-ee4j:8.0 Apr 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants