Fix initial lookup delay for client applications #24947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a unnecessary calling
inetSocketAddress.getHostName()in the methodorg.glassfish.enterprise.iiop.impl.IIOPSSLSocketFactory.createSocket().The
inetSocketAddress.getHostName()method performs a reverse DNS lookup from theinetSocketAddress.It can take a long time to process depending on the environment, particularly when the corresponding host name cannot be found in DNS and times out.
For non-TLS connections, the reverse DNS lookup is not required.
However,
inetSocketAddress.getHostName()is called regardless of the connection type in the current impl.By applying this changes, the response is faster in some cases.
For example, using an IP address without a host name for (non-TLS) IIOP connections.