Context root doesn't include a random string #24984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For apps deployed via Admin Console, the uploaded file was copied to a temp file, which contained a random string. Now, the temp directory has a random string, but the file in it has the same name. Context root is generated from the file name and doesn't include a random string with this commit. Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
hs536
approved these changes
Jun 10, 2024
dmatej
approved these changes
Jun 10, 2024
appserver/admingui/core/src/main/java/org/glassfish/admingui/handlers/WoodstockHandler.java
Show resolved
Hide resolved
- also remove after file is uploaded - improve file handling for uploaded files - give an error in GUI if IOException Signed-off-by:Ondro Mihalyi <mihalyi@omnifish.ee>
dmatej
reviewed
Jun 13, 2024
appserver/admingui/core/src/main/java/org/glassfish/admingui/handlers/WoodstockHandler.java
Show resolved
Hide resolved
OndroMih
added a commit
to OndroMih/glassfish
that referenced
this pull request
Jun 14, 2024
Response to comment in eclipse-ee4j#24984
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For apps deployed via Admin Console, the uploaded file was copied to a temp file, which contained a random string. Now, the temp directory has a random string, but the file in it has the same name.
Context root is generated from the file name and doesn't include any random string with this commit.
Before, when an app was deployed with default values:
Now:
