Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update EE4J/parent to 1.0.9 #25028

Merged
merged 1 commit into from
Jul 6, 2024
Merged

Update EE4J/parent to 1.0.9 #25028

merged 1 commit into from
Jul 6, 2024

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jul 5, 2024

@pzygielo pzygielo marked this pull request as ready for review July 5, 2024 16:04
@avpinchuk
Copy link
Contributor

Parent update give us a lot of warnings (in GF 8 too):

[2024-07-05T12:13:49.009Z] [WARNING] *****************************************************************
[2024-07-05T12:13:49.009Z] [WARNING] * An aggregator mojo is already being executed in this          *
[2024-07-05T12:13:49.009Z] [WARNING] * parallel build, those kind of mojos require exclusive access  *
[2024-07-05T12:13:49.009Z] [WARNING] * to reactor to prevent race conditions. This mojo execution    *
[2024-07-05T12:13:49.009Z] [WARNING] * will be blocked until the aggregator mojo is done.            *
[2024-07-05T12:13:49.009Z] [WARNING] *****************************************************************

Is it correct?

@pzygielo
Copy link
Contributor Author

pzygielo commented Jul 5, 2024

Parent update give us a lot of warnings (in GF 8 too):
Is it correct?

Not sure why maven does that as warning MNG-7476, if it's completely handled on its side:

String msg = str + " aggregator mojo is already being executed "
+ "in this parallel build, those kind of mojos require exclusive access to "
+ "reactor to prevent race conditions. This mojo execution will be blocked "
+ "until the aggregator mojo is done.";
warn(msg);

But now we know, that that happens.

@dmatej
Copy link
Contributor

dmatej commented Jul 5, 2024

It is ok, we can see the same in the 8.0 branch. Also this update slows down the build, that is why we made #24997 and then #25026. I will play with the CycloneDX in next few days (it depends on how much tired I am).

@dmatej dmatej added this to the 7.0.16 milestone Jul 5, 2024
@dmatej dmatej added the component upgrade A component dependency has been upgraded label Jul 5, 2024
@pzygielo pzygielo merged commit f0766c8 into eclipse-ee4j:master Jul 6, 2024
2 checks passed
@pzygielo pzygielo deleted the ep branch July 6, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component upgrade A component dependency has been upgraded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants