Enhancement: Respect scheme from the serverName listener property in redirect URLs #25044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arjantijms
reviewed
Jul 15, 2024
| * The HTTP scheme to which we should pretend requests to this Connector were directed. This is useful when operating | ||
| * GlassFish behind a proxy server, so that redirects get constructed accurately. | ||
| */ | ||
| private String proxyScheme = null; |
There was a problem hiding this comment.
It's extremely minor, but null is already the default and can be left out.
arjantijms
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ServerName property on the HTTP listener can contain scheme prefix (e.g. https://), which will be respected in redirects created by GlassFish.
For example, if GlassFish is behind a proxy server, connections to the proxy server go through HTTPS but connections from proxy server to GlassFish go through HTTP. If the proxy server is exposed at https://my.domain.com, then it's possible to set the serverName to https://my.domain.com:443 to use https://my.domain.com/ in redirects. This URL doesn't have to be translated by the proxy server because it's the correct URL where the proxy server listens to incoming requests.
This resolves #24918.