Fix for a ClassCastException when a filter over a WebSocket endpoint wraps the request #25107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmatej
approved these changes
Aug 23, 2024
Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
dmatej
force-pushed
the
ondromih-gh24712-webSocket-default-web-module
branch
from
23a0bcb
to
03c40fa
Compare
|
I have rebased the PR and resolved the conflict. Also note that there are two tests failing on JDK23 and this is one of them. It is not important for the PR, just to know ... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24712.
Makes the cast to RequestFacade more robust - only if cast is allowed, searches through the chain of wrapped requests.
Added tests for the case fixed in #24691 and also for the case described in #24712.