Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide "Trying to get this manpage" messages for asadmin --help #25135

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

OndroMih
Copy link
Contributor

@OndroMih OndroMih commented Sep 8, 2024

Asadmin sets log level to FINE by default, unless --terse option is used. The "Trying to get this manpage" messages are useless for users, and there are many of them logged for by each asadmin command with --help option. Running asadmin with AS_DEBUG=true environment variable enables these messages if needed.

Current behavior:

The output of command asadmin --help prints the following at the beginning:

Trying to get this manpage: com/sun/enterprise/admin/cli/en/asadmin.9
Trying to get this manpage: com/sun/enterprise/admin/cli/en/asadmin.9m
Trying to get this manpage: com/sun/enterprise/admin/cli/en/asadmin.5asc
Trying to get this manpage: com/sun/enterprise/admin/cli/asadmin.1
Trying to get this manpage: com/sun/enterprise/admin/cli/asadmin.1m
asadmin(1M)                    Utility Commands                    asadmin(1M)

NAME
       asadmin - utility for performing administrative tasks for Oracle
       GlassFish Server

Only with the --terse option (asadmin --help --terse), the output doesn't contain the "Trying to get this manpage..." lines.

With the fix in this PR, the output of asadmin --help doesn't contain the "Trying to get this manpage..." lines. Same as the current behavior of asadmin --help --terse:

asadmin(1M)                    Utility Commands                    asadmin(1M)

NAME
       asadmin - utility for performing administrative tasks for Oracle
       GlassFish Server

If needed, the "Trying to get this manpage..." lines can be displayed by setting the AS_DEBUG or AS_TRACE env variables to true, for example:

AS_DEBUG=true asadmin --help

Asadmin sets log level to FINE by default, unless --terse option is used. The "Trying to get this manpage" messages are useless for users, and there are many of them logged for by each asadmin command with --help option. Running asadmin with AS_DEBUG=true environment variable enables these messages if needed.
@pzygielo pzygielo added this to the 7.0.18 milestone Sep 8, 2024
@pzygielo pzygielo merged commit b4bd2e2 into eclipse-ee4j:master Sep 9, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants