Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed masking passwords in a map used for logging in admingui + added warning to documentation #25144

Merged
merged 2 commits into from
Sep 14, 2024

Conversation

dmatej
Copy link
Contributor

@dmatej dmatej commented Sep 13, 2024

  • This was discussed on GitLab - the bug was reported there
  • I added warning about sharing logs into documentation on three appropriate places:
    • To the introduction of the logging documentation
    • To the part about configuring log levels
    • To the list of recommendations in the security guide
  • In general passwords are not the only thing which can be misused to compromise some production system. People should be careful when they share logs, especially when they configured more verbose log levels. Internal host names, distinguished names of internal certificates, dumped HTTP communication, TLS negotiations, ....

- Passwords were masked off, but then it logged the original map.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
…n logs

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej added bug Something isn't working Documentation labels Sep 13, 2024
@dmatej dmatej added this to the 7.0.18 milestone Sep 13, 2024
@dmatej dmatej self-assigned this Sep 13, 2024
@dmatej dmatej merged commit 6ed2f5b into eclipse-ee4j:master Sep 14, 2024
2 checks passed
@dmatej dmatej deleted the passwords branch September 17, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants