Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Part 1,2,3,4 for issue #24900 Document and rename some ResourceHandle fields. #25155

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

escay
Copy link
Contributor

@escay escay commented Sep 23, 2024

Part 1 for issue #24900 Document and rename some ConnectionPool fields.
Remove some unused methods and constructor parameters. Functional / possible incompatibility changes in DataStructureFactory and in ResourceHandle due to constructor changes.

Part 2 for issue #24900 Start with a new PoolManagertImpl unit test to understand enlisted versus busy states of Resource handles and the wiring inside a transaction to keep track of all used resources.

Part 3 for issue #24900 More documentation and more unit test coverage.

Part 4 for issue #24900 Add more detailed logging to improve log file analysis.

…Handle fields.

Document and rename some ConnectionPool fields.
Remove some unused methods and constructor parameters.
Functional / possible incompatibility changes in DataStructureFactory
and in ResourceHandle due to constructor changes.

Part 2 for issue eclipse-ee4j#24900 Start with a new PoolManagertImpl unit test to
understand enlisted versus busy states of Resource handles and the
wiring inside a transaction to keep track of all used resources.

Part 3 for issue eclipse-ee4j#24900 More documentation and more unit test coverage.

Part 4 for issue eclipse-ee4j#24900 Add more detailed logging to improve log file
analysis.
@dmatej
Copy link
Contributor

dmatej commented Sep 29, 2024

Tests passed except several which were broken by yasson which contains JDK17 based classes unusable with JDK11. However we should merge this PR as nothing else broke.

Details about poisoned staging repo:

  • The repo is ok now, I checked yasson for sure
  • My computer was poisoned too, so it seems that around this date the yasson.jar in staging was broken:
    #NOTE: This is a Maven Resolver internal implementation file, its format can be changed without prior notice.
    #Wed Jul 24 22:13:51 CEST 2024
    yasson-3.0.4-javadoc.jar>staging=
    yasson-3.0.4-sources.jar>staging=
    yasson-3.0.4.jar>staging=
    yasson-3.0.4.pom>staging=
    
  • yasson with the same version in Maven Central is compiled for Java 11, but this file used Java 17 and cannot be used with 11.
  • GlassFish 7.0.17 contains correct version.

@dmatej dmatej merged commit 73dbced into eclipse-ee4j:master Sep 30, 2024
2 checks passed
@escay escay deleted the issue_24900_v2 branch October 9, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants