Fixed #276: Added special handling for Optional<> JsonbCreator arguments #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Minto van der Sluis <minto@xup.nl>
aguibert
reviewed
Jun 27, 2019
There was a problem hiding this comment.
I think this PR is a duplicate/alternate solution to PR #237. Unfortunately I don't think we can merge either of these until we resolve this design at the JSON-B spec level over at jakartaee/jsonb-api#121 -- lets focus our efforts on getting that JSON-B issue closed out and then we can likely go with one of these two PRs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #276
Signed-off-by: Minto van der Sluis minto@xup.nl