[enhancement] Retrieve and build protobuf from remote URLs #157
Assignees
Labels
enhancement
New feature or request
Comments
wilyle
added a commit
that referenced
this issue
Mar 13, 2024
Currently, Freyja is using cargo git dependencies to reference the proto packages from other ESDV projects such as Ibeji. This has caused compatibility issues and needs to be updated. This PR makes a change to pull the content from a remote URL and build the proto files within the Freyja repo. Inspired by UProtocol: https://github.com/eclipse-uprotocol/up-rust/blob/main/build.rs Also makes a minor update to the install instructions in the README, which required updating the markdown-ci workflow due to a recent regression in the tool that it uses (see tcort/markdown-link-check#304) Fixes #157
wilyle
added a commit
that referenced
this issue
Mar 15, 2024
Target specific versions for remote protobuf files. Based on anticipated changes in Ibeji targeting main was determined to be unreliable, so a solution was found which reduces the management overhead of trying to maintain the referenced versions. This revises #157
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Currently, Freyja is using cargo git dependencies to reference the proto packages from other ESDV projects such as Ibeji. This has caused compatibility issues and needs to be updated. The dependent projects are using submodules to bring in their proto files, but this is also undesirable. The proposed solution is to retrieve the raw proto content with a URL and build from the
OUT_DIR, similar to how UProtocol builds their protobuf files: https://github.com/eclipse-uprotocol/up-rust/blob/main/build.rsAcceptance criteria
OUT_DIRThe text was updated successfully, but these errors were encountered: