Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correction proposal that preserves underlying "linked" nature. #3267

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

rgrunber
Copy link
Contributor

@rgrunber rgrunber commented Sep 6, 2024

Screencast.from.2024-09-06.15-05-50.mp4
  • "Add missing attributes" (annotation), "Add all missing tags" (javadoc), "Add ... tag" (javadoc)

Without this change, such corrections weren't linked proposals because we cast to a subclass that didn't support it.

- "Add missing attributes" (annotation), "Add all missing tags"
  (javadoc), "Add ... tag" (javadoc)

Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@rgrunber rgrunber added this to the End September 2024 milestone Sep 6, 2024
@rgrunber rgrunber merged commit a703baf into eclipse-jdtls:master Sep 9, 2024
6 of 7 checks passed
@rgrunber rgrunber deleted the fix-linked-proposals branch September 9, 2024 12:20
@rgrunber rgrunber self-assigned this Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant