Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide integration test for the CLI get command #118

Closed
k-gostev opened this issue Jan 26, 2023 · 1 comment · Fixed by #129
Closed

Provide integration test for the CLI get command #118

k-gostev opened this issue Jan 26, 2023 · 1 comment · Fixed by #129
Assignees
@daniel-milchev
Labels
task Single unit of work
Milestone
M3

Comments

@k-gostev
Copy link
Member

Integration tests for the CLI capabilities, based on #96 and the framework implemented there should be provided for the get command of kanto-cm. The command output should covered by implementing custom result function. The help (-h) output must be tested using golden files.
@k-gostev k-gostev added the task Single unit of work label Jan 26, 2023
@k-gostev k-gostev added this to the M3 milestone Jan 26, 2023
@dimitar-dimitrow dimitar-dimitrow changed the title CLI integration test for the get command Provide integration test for the CLI get command Jan 26, 2023
@dimitar-dimitrow dimitar-dimitrow mentioned this issue Jan 26, 2023
Open
@daniel-milchev
Copy link
Contributor

I'll have a look at this.

daniel-milchev added a commit to bosch-io/container-management that referenced this issue Feb 7, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
2f009ae 
Created golden file and test case scenarios with exit code 1.

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
@daniel-milchev daniel-milchev mentioned this issue Feb 7, 2023
Merged
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Feb 7, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
156d6f1 
Created golden file and test case scenarios with exit code 1.

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Mar 7, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
470c916 
Created golden file and test case scenarios with exit code 1.

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Mar 7, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
d5367af 
Added more tests

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Mar 20, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
8c8c8fa 
Removed the new CLITest struct, reverted some changes, created an init func and made a setter for customResultFns map

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Mar 20, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
44e9bcc 
Changed the name of the function to AddCustomResult and fixed some comments.

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Mar 20, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
4ca98c4 
Added missing build integration tag.

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Mar 20, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
d5b855f 
Created golden file and test case scenarios, created an init function and an add fuction for the customResultFns map and unmarshaled the data.

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
@k-gostev k-gostev linked a pull request Mar 20, 2023 that will close this issue
Provide integration test for the CLI get command #129
Merged
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Mar 20, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
bedb67c 
Created golden file and test case scenarios, created an init function and an add fuction for the customResultFns map and unmarshaled the data.

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Mar 20, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
5c8c584 
Created golden file and test case scenarios, created an init function and an add fuction for the customResultFns map and unmarshaled the data.

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
daniel-milchev added a commit to bosch-io/container-management that referenced this issue Mar 20, 2023
@daniel-milchev
[eclipse-kanto#118] Provide integration test for the CLI get command
32cc175 
Fixed the wording of the comment

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
dimitar-dimitrow pushed a commit that referenced this issue Mar 20, 2023
@daniel-milchev
Provide integration test for the CLI get command (#129)
65e0035 
[#118] Provide integration test for the CLI get command
Created golden file and test case scenarios, created an init function and an add function for the customResultFns map and unmarshaled the data.

Signed-off-by: Daniel Milchev <fixed-term.daniel.milchev@bosch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daniel-milchev daniel-milchev

Labels
task Single unit of work
Projects
Eclipse Kanto
Status: Done
Milestone
M3
Development

Successfully merging a pull request may close this issue.

Provide integration test for the CLI get command bosch-io/container-management
2 participants
@daniel-milchev @k-gostev