Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide integration test for the CLI sysinfo, logs and update commands #119

Closed
k-gostev opened this issue Jan 26, 2023 · 0 comments · Fixed by #125
Closed

Provide integration test for the CLI sysinfo, logs and update commands #119

k-gostev opened this issue Jan 26, 2023 · 0 comments · Fixed by #125
Assignees
@dimitar-dimitrow
Labels
task Single unit of work
Milestone
M3

Comments

@k-gostev
Copy link
Member

Integration tests for the CLI capabilities, based on #96 and the framework implemented there should be provided for the sysinfo, logs and update commands of kanto-cm. Some commands output may require to be covered covered by implementing custom result function. The help (-h) output must be tested using golden files.
@k-gostev k-gostev added the task Single unit of work label Jan 26, 2023
@dimitar-dimitrow dimitar-dimitrow changed the title CLI integration test for the sysinfo, logs and update commands Provide integration test for the CLI sysinfo, logs and update commands Jan 26, 2023
@dimitar-dimitrow dimitar-dimitrow mentioned this issue Jan 26, 2023
Open
@k-gostev k-gostev added this to the M3 milestone Jan 30, 2023
@dimitar-dimitrow dimitar-dimitrow self-assigned this Jan 30, 2023
dimitar-dimitrow added a commit to bosch-io/container-management that referenced this issue Feb 2, 2023
@dimitar-dimitrow
[eclipse-kanto#119] Provide integration test for the CLI sysinfo, log…
0cdea81 
…s and update commands

 - added integration tests for sysinfo, update and logs CLI commands
 - implemented custom result function for logs command
 - fixed stop_invalid_id test

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
@dimitar-dimitrow dimitar-dimitrow mentioned this issue Feb 2, 2023
Merged
@dimitar-dimitrow dimitar-dimitrow linked a pull request Feb 2, 2023 that will close this issue
Provide integration test for the CLI sysinfo, logs and update commands #125
Merged
dimitar-dimitrow added a commit to bosch-io/container-management that referenced this issue Feb 3, 2023
@dimitar-dimitrow
[eclipse-kanto#119] Addressing comments
39ce0e4 
 - fail fast on improper LOG_JSON argument
 - return true on successful validation
 - add custom result check for logs_of_container_with_state_stopped test

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
dimitar-dimitrow added a commit that referenced this issue Feb 6, 2023
@dimitar-dimitrow
Provide integration test for the CLI sysinfo, logs and update commands (
4108c97 
#125)

[#119] Provide integration test for the CLI sysinfo, logs and update commands

 - added integration tests for sysinfo, update and logs CLI commands
 - implemented custom result function for logs command
 - fixed stop_invalid_id test

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimitar-dimitrow dimitar-dimitrow

Labels
task Single unit of work
Projects
Eclipse Kanto
Status: Done
Milestone
M3
Development

Successfully merging a pull request may close this issue.

Provide integration test for the CLI sysinfo, logs and update commands bosch-io/container-management
2 participants
@dimitar-dimitrow @k-gostev