Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide integration tests via the key Ditto features - ContainerFactory #70

Closed
konstantina-gramatova opened this issue Sep 30, 2022 · 0 comments · Fixed by #79
Closed
Assignees
Labels
task Single unit of work
Milestone

Comments

@konstantina-gramatova
Copy link
Contributor

E2E tests via the component's Ditto API must ensure that controlling the service remotely and pushing out updates works.

The ContainerFactory Ditto feature and its capabilities have to be covered.

@konstantina-gramatova konstantina-gramatova added the task Single unit of work label Sep 30, 2022
@konstantina-gramatova konstantina-gramatova added this to the M3 milestone Sep 30, 2022
@antoniyatrifonova antoniyatrifonova self-assigned this Sep 30, 2022
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 1, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- add integration test for operation create
- add integration test for operation createWithConfig

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 7, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- downgrade the paho version in go.mod
- assert for ContinerFactory feature
- assert that all events related with the container creation are received
- add new test method for 'createWithConfig' operation that checks the continaer state
- rename environment variables
- improve the names of the variables

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 8, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- improve error messages
- if some test failed, the container is not removed. The TearDown method should clean up the created containers

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 9, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- change the github.com/stretchr/testify version to 1.8.1
- improve some method and variable names
- in case of error the test has to failed, not only log the error

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 14, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the code to use the common logic

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 14, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- add integration build tag

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 15, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- add integration test for operation create
- add integration test for operation createWithConfig

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 15, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- downgrade the paho version in go.mod
- assert for ContinerFactory feature
- assert that all events related with the container creation are received
- add new test method for 'createWithConfig' operation that checks the continaer state
- rename environment variables
- improve the names of the variables

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 15, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- improve error messages
- if some test failed, the container is not removed. The TearDown method should clean up the created containers

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 15, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- change the github.com/stretchr/testify version to 1.8.1
- improve some method and variable names
- in case of error the test has to failed, not only log the error

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 15, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the code to use the common logic

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 15, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- add integration build tag

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 15, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- if the test failed, the container feature must be removed in teardown method

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 15, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- remove go.mod.orig file

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 18, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- add integration test for operation create
- add integration test for operation createWithConfig

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 18, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- downgrade the paho version in go.mod
- assert for ContinerFactory feature
- assert that all events related with the container creation are received
- add new test method for 'createWithConfig' operation that checks the continaer state
- rename environment variables
- improve the names of the variables

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 18, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- improve error messages
- if some test failed, the container is not removed. The TearDown method should clean up the created containers

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 18, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- change the github.com/stretchr/testify version to 1.8.1
- improve some method and variable names
- in case of error the test has to failed, not only log the error

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 18, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the code to use the common logic

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 18, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- add integration build tag

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 18, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- if the test failed, the container feature must be removed in teardown method

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 18, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the code

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 18, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- add build tag

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
antoniyatrifonova added a commit to bosch-io/container-management that referenced this issue Nov 23, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the code to use the common test logic
- improve error messages

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- improve error messages
- if some test failed, the container is not removed. The TearDown method should clean up the created containers

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- change the github.com/stretchr/testify version to 1.8.1
- improve some method and variable names
- in case of error the test has to failed, not only log the error

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the code to use the common logic

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- add integration build tag

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- if the test failed, the container feature must be removed in teardown method

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the code

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- add build tag

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the code to use the common test logic
- improve error messages

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- move methods in common file
- simplify the names of the test function

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- improve the error handling

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- separate the common code
- create constants
- improve the method names
- improve the error messages

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- move event assertion in common file
- refactor the constants

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- use the common method to get the property value

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- close the websocket conenction if the test failed

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- remove go:build tag from the common file
- fix the issue with the deffer function

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- update to the latest integration testing util
- extract the common constants in separate file
- update the ContainerFactory definition version

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the constants

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor create function

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the usage of contants

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refactor the event process function

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- fix the review comments

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- fix golint issues

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- fix comments

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- refine the cleanup process

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- first unsubscribe for the ws messages after that close ws connection

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- close ws connection when containerID is empty
Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- the ws connection is closed twice - fixed
Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit to bosch-io/container-management that referenced this issue Dec 16, 2022
[eclipse-kanto#70] Provide integration tests via the key Ditto features - ContainerFactory
- check ws connection for nil value

Signed-off-by: Guzgunova Antonia <Antonia.Guzgunova@bosch.io>
konstantina-gramatova pushed a commit that referenced this issue Dec 16, 2022
…ry (#79)

[#70] Provide integration tests via the key Ditto features - ContainerFactory

- provide initial integration test setup for container-management components
- provide initial integration tests for the ContainerFactory feature

Signed-off-by: Guzgunova Antonia Antonia.Guzgunova@bosch.io
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Single unit of work
Projects
Status: Done
2 participants